Refactoring Branch #79
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Refactor 24 73 file type descriptions
76 basic outline of new data types
76 basic outline of new data types
Unit parsing
For now, I'm just specifying all of them in the regex. This should work for now because there aren't many symbols to specify, and I'm not sure what else would work without allowing symbols that shouldn't really be allowed.
Unit unicode symbol fix
… refactor_24 # Conflicts: # sasdata/quantities/accessors.py # sasdata/temp_hdf5_reader.py
…ns for ineptitudes.
sasdata/transforms/operation.py
Outdated
| @@ -0,0 +1,19 @@ | |||
| import numpy as np | |||
| from sasdata.quantities.quantity import Quantity | |||
There was a problem hiding this comment.
Can this file be deleted now? Seems to just be a sketch which has now been implemented in operations.py.
|
|
||
| entry_keys = [key for key in entry.keys()] | ||
|
|
||
| if "sasdata" not in entry_keys and "data" not in entry_keys: |
There was a problem hiding this comment.
Does this account for the situation where entry_keys contains something like 'sasdata01'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main branch for the refactoring project